Parse videopress media details #841
Merged
+34
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oguzkocer
approved these changes
Aug 18, 2025
Atomic sites (maybe all sites with Jetpack Videopress enabled) returns a `media_details` JSON object that is not compatible with the one in core. That means the `parse_as_mime_type` function does not return `VideoMediaDetails`. We want to add a dedicated function to parse the `media_details` values provide by the VideoPress plugin.
crazytonyli
force-pushed
the
parse-videopress
branch
from
66efcb1 to
5e6f064
Compare
|
Rebased to include changes in #842. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Atomic sites (maybe all sites with Jetpack Videopress enabled) returns a
media_detailsJSON object that is not compatible with the one in core. That means theparse_as_mime_typefunction does not returnVideoMediaDetails.We want to add a dedicated function to parse the
media_detailsvalues provide by the VideoPress plugin.